[ruby-cvs:68762] naruse:r61581 (ruby_2_5): merge revision(s) 61497: [Backport #14243]

naruse at ruby-lang.org naruse at ruby-lang.org
Thu Jan 4 03:11:47 JST 2018


naruse	2018-01-04 03:11:47 +0900 (Thu, 04 Jan 2018)

  New Revision: 61581

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=61581

  Log:
    merge revision(s) 61497: [Backport #14243]
    
    erb.rb: preserve the behavior for invalid syntax
    
    comment. Fix regression at r58948.
    
    I even don't want to deprecate it because deprecation needs to lex all
    embedded Ruby script using Ripper and it would be slow.  So Let me just
    keep this behavior of Ruby 2.4. No change is the best compatibility.
    
    This commit stopped using String#-@ because it's harmful for "ambiguous
    first argument" warning if we really want to maintain this behavior.
    
    [Bug #14243]

  Modified directories:
    branches/ruby_2_5/
  Modified files:
    branches/ruby_2_5/lib/erb.rb
    branches/ruby_2_5/test/erb/test_erb.rb
    branches/ruby_2_5/version.h


More information about the ruby-cvs mailing list