[ruby-cvs:66253] Re: ko1:r59074 (trunk): fix to free unallocated memory.

Eric Wong normalperson at yhbt.net
Wed Jun 14 07:29:05 JST 2017


ko1 at ruby-lang.org wrote:
>   New Revision: 59074
> 
>   https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=59074
> 
>   Log:
>     fix to free unallocated memory.
>     
>     * compile.c (iseq_set_sequence): initialize with NULL for line_info_table
>       and generated_iseq and check NULL at BADINSN_ERROR.

I don't think the change to BADINSN_ERROR is necessary.

xfree (and free) already allow NULL arg; and optimizing away a
a function call with extra branch isn't worth it for error handling.

Thanks.

> 
>   Modified files:
>     trunk/compile.c


More information about the ruby-cvs mailing list