[ruby-cvs:66452] usa:r59274 (ruby_2_3): This backport of r58812 is necessary to ease backporting r59028,

usa at ruby-lang.org usa at ruby-lang.org
Fri Jul 7 11:03:22 JST 2017


usa	2017-07-07 11:03:22 +0900 (Fri, 07 Jul 2017)

  New Revision: 59274

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=59274

  Log:
    This backport of r58812 is necessary to ease backporting r59028,
    which fixes a real bug.
    
    * thread.c (struct waiting_fd): declare
      (rb_thread_io_blocking_region): use on-stack list waiter
      (rb_notify_fd_close): walk vm->waiting_fds instead
      (call_without_gvl): remove old field setting
      (th_init): ditto
      [Feature #9632]
    
    * vm_core.h (typedef struct rb_vm_struct): add waiting_fds list
    
    * (typedef struct rb_thread_struct): remove waiting_fd field
      (rb_vm_living_threads_init): initialize waiting_fds list
    
    This should fix bad interactions with test_race_gets_and_close
    in test/ruby/test_io.rb since we ensure rb_notify_fd_close
    continues returning the busy flag after enqueuing the interrupt.
    
    * thread.c (rb_notify_fd_close): do not enqueue multiple interrupts
      [ruby-core:81581] [Bug #13632]
    
    * test/ruby/test_io.rb (test_single_exception_on_close):
      new test based on script from Nikolay

  Modified files:
    branches/ruby_2_3/ChangeLog
    branches/ruby_2_3/test/ruby/test_io.rb
    branches/ruby_2_3/thread.c
    branches/ruby_2_3/version.h
    branches/ruby_2_3/vm.c
    branches/ruby_2_3/vm_core.h


More information about the ruby-cvs mailing list